Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset i18n: redirect back to previous page after changing language setting #299

Open
1 task
pomegranited opened this issue Nov 15, 2024 · 1 comment · May be fixed by apache/superset#31692
Open
1 task
Assignees
Labels
aspects enhancement Relates to new features or improvements to existing features

Comments

@pomegranited
Copy link
Contributor

pomegranited commented Nov 15, 2024

Description

The original issue states:

When changing the language, Superset redirects the user to the homepage, regardless of the current page. Although I understand that a restart might be necessary for language changes to take effect, it would be more user-friendly if the user remained on the page they were working on after the restart.

However there seems to be a "previous page" stored in the user's session somewhere, because after visiting the User Info page (/users/userinfo/), this became my go-to page instead of the home page for redirects after changing my language.

Supporting Information

Proposed solution

Investigate further, and choose an appropriate option.

Option 1: Fix "previous page" setting

  • Determine where the "previous page" setting is stored and updated in the user's session
  • Ensure this setting gets updated whenever the "current page" changes.

Option 2: Store "next page" as URL param on language change

  • As with the "login" screen, store the "current page" path as a next URL parameter when changing the user's preferred language
  • Ensure this next parameter is used when deciding where to redirect after changing the user's preferred language.

Aspects specifics

  • Ensure the solution is backported to the Superset version used by Aspects.
@bmtcril
Copy link
Contributor

bmtcril commented Nov 15, 2024

Just noting that this is an upstream Superset enhancement, but is an improvement we want for Aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspects enhancement Relates to new features or improvements to existing features
Projects
Status: Doing
Development

Successfully merging a pull request may close this issue.

2 participants