Only run Python tests when PR contains more than .po's #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All translation files are valid. This comment has been posted by the |
sarina
force-pushed
the
sarina/python-tests-action
branch
from
3de9c5c to
aeef38d
Compare
|
@brian-smith-tcril hmm this is interesting, when the test doesn't run via this mechanism, it just shows the test as pending. I guess we have to do something different, like testing the filepath ourselves and give it a mock pass? |
|
OK, using this action - https://github.com/dorny/paths-filter#examples - is what's best. |
sarina
force-pushed
the
sarina/python-tests-action
branch
from
c4ecc95 to
3fcf411
Compare
sarina
force-pushed
the
sarina/python-tests-action
branch
from
3fcf411 to
972b190
Compare
brian-smith-tcril
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brian-smith-tcril I think this will work based on https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths