Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improves the installation instructions #23

Closed
wants to merge 1 commit into from

Conversation

imasdekar
Copy link

  • Changes the flow of some installation steps which I found to be confusing.
  • Also adds missing instructions to install some plugins before enabling them.

Signed-off by: Ishan Masdekar [email protected]

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 21, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 21, 2024

Thanks for the pull request, @imasdekar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@imasdekar
Copy link
Author

I have signed the CLA

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 22, 2024
@mphilbrick211
Copy link

Hi @imasdekar! Thanks for this contribution, and for submitting your CLA form. I will look into getting checks enabled on this pull request.

@imasdekar imasdekar changed the title update: Improves the installation instructions docs: improves the installation instructions Apr 26, 2024
@imasdekar
Copy link
Author

I have fixed the commit lint for which the checks failed

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 1, 2024
@imasdekar
Copy link
Author

@openedx/cla-problems I have already submitted the signed cla days ago. Am I still missing something?

@mphilbrick211
Copy link

Hi @imasdekar! Our legal team sent you an email just now with some next steps.

@imasdekar
Copy link
Author

imasdekar commented May 15, 2024

@mphilbrick211 I have already clarified this twice on email with Eden Huthmacher (got the replies on it as well) about my personal email. But I do not know why it is being flagged again. Hence explaining it again here in comments.

My email address [email protected] is my personal/individual email address and not associated to any organization. It is provided by disroot.org which is an independent mail provider just like gmail or any other and not an organization where I work.

Also 2nd reason for declining my cla was my missing mailing address. However in the cla form here i can see that mailing address is a mandatory field(* marked). So I do not think that I proceeded without providing my mailing address.

Let me know if you still want me to re-submit it.

@mphilbrick211
Copy link

@mphilbrick211 I have already clarified this twice on email with Eden Huthmacher (got the replies on it as well) about my personal email. But I do not know why it is being flagged again. Hence explaining it again here in comments.

My email address [email protected] is my personal/individual email address and not associated to any organization. It is provided by disroot.org which is an independent mail provider just like gmail or any other and not an organization where I work.

Also 2nd reason for declining my cla was my missing mailing address. However in the cla form here i can see that mailing address is a mandatory field(* marked). So I do not think that I proceeded without providing my mailing address.

Let me know if you still want me to re-submit it.

Hi @imasdekar - I'm checking on this for you!

@imasdekar
Copy link
Author

@mphilbrick211 The frontend-app-library-authoring repo is archived. Hence this PR is not required any more.

@imasdekar imasdekar closed this Aug 2, 2024
@openedx-webhooks
Copy link

@imasdekar Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants