Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discovery] Attempt to get the semantic release version preview on CI working again #2778

Closed
adamstankiewicz opened this issue Nov 6, 2023 · 1 comment · Fixed by #2871
Closed
Assignees

Comments

@adamstankiewicz
Copy link
Member

No description provided.

@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Nov 6, 2023
@monteri monteri moved this from To Do to In progress in Paragon Working Group Nov 21, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Nov 28, 2023
@viktorrusakov viktorrusakov linked a pull request Dec 6, 2023 that will close this issue
10 tasks
@monteri monteri moved this from In review to In progress in Paragon Working Group Dec 7, 2023
@viktorrusakov
Copy link
Contributor

@adamstankiewicz I'm closing this because there is now way we can make semantic release work for all PRs right now. I've tried a bunch of stuff but it all comes down to the fact that we cannot preview new semantic release version on the PRs opened from forked repositories because semantic-release package requires push access to the repository even when you use --dry-run option (do not ask me why, I have no idea why they made it this way...), which we obviously do not have.

I could make preview work only on PRs from upstream repository, but that's not enough considering that majority of PRs we have are coming from RacoonGang's fork, so this CI step would just fail on most PRs (and for other open-source contributors as well)

I've removed this step from our pipeline as a result (I don't think it was particularly useful anyway to be honest).

@github-project-automation github-project-automation bot moved this from In progress to Done in Paragon Working Group Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants