Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: checkout repos from openedx insted of edx in analyze depedents workflow #3089

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

Description

Updates most of the repos in the analyze dependents workflow to checkout from openedx/ instead of edx/

Verified via a workflow run on my fork https://github.com/brian-smith-tcril/paragon/actions/runs/9486407270/job/26140657441

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 592f417
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6669d08655abc10008654e5f
😎 Deploy Preview https://deploy-preview-3089--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully having prospectus in here won't cause it to break. It's also still questionable whether prospectus really should be in here at all given it's technically a private repo for 2U, and may cause an error to occur if the workflow doesn't have the correct permissions to clone it.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (13bca51) to head (592f417).
Report is 181 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3089   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         249      249           
  Lines        4359     4359           
  Branches     1034     1034           
=======================================
  Hits         4063     4063           
+ Misses        293      290    -3     
- Partials        3        6    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril
Copy link
Contributor Author

Hopefully having prospectus in here won't cause it to break. It's also still questionable whether prospectus really should be in here at all given it's technically a private repo for 2U, and may cause an error to occur if the workflow doesn't have the correct permissions to clone it.

Yeah, I commented it out for the workflow run on my fork since I don't have the SEMANTIC_RELEASE_GITHUB_TOKEN there, I figure we can merge this as is and try running it - if prospectus ends up still being problematic I'll make a new PR removing it.

@brian-smith-tcril brian-smith-tcril merged commit 3674557 into openedx:master Jun 12, 2024
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 22.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants