-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Pull Request] disable forum digest subscription section by default #235
Comments
Thanks for your submission, @openedx/open-edx-project-managers will review shortly. |
Information from the original PR: Current state of the featureInitially, this feature used the Notifier Django app but was deprecated and removed from the configuration in favor of edx-notifications. More info about this deprecation can be found in the GitHub issue. The edx-notifications app was not supported though, so its repository was archived and moved to GitHub - openedx-unsupported/edx-notifications. Check the deprecation ticket and corresponding discussion for details. What remains in the edx-platformThe forum's initial page contains the how-to info with the notification preferences toggle: This section is responsible for toggling the "notification_pref" user preference (aka NOTIFICATION_PREF_KEY). I didn't find any usage of this preference across the platform, so I'm suggesting hiding it by default by setting the ENABLE_FORUM_DAILY_DIGEST setting default value to |
Needs a product review from Aamir: Can you confirm that "notification_pref" is not used anywhere across the platform? |
Aamir approved openedx/edx-platform#31459 (comment) |
@mphilbrick211 just wanted to confirm that you saw the "done" status of this one? |
Closing as this is marked "Shipped" on the PR board 🎉 |
For Contributing Author:
This is the Primary Product Ticket for the following community contribution: Make course description editable in certificates
Checklist prior to undergoing Product Review:
The following information is required in order for Product Managers to be able to review your pull request:
Only if necessary:
Related PRs
For Product Manager doing the review:
What criteria should be analyzed from Product to approve a PR?
The text was updated successfully, but these errors were encountered: