Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Pull Request] disable forum digest subscription section by default #235

Closed
4 of 7 tasks
jmakowski1123 opened this issue Feb 22, 2023 · 6 comments
Closed
4 of 7 tasks
Labels
product review complete PR has gone through product review

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Feb 22, 2023

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: Make course description editable in certificates

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

  • Explanation of the problem being solved
  • Description of how users will be impacted, and which users will be impacted
  • Screenshots or video showing the functionality or fix, before and after
  • Reproduction steps and/or testing steps

Only if necessary:

  • If necessary, links to corresponding configuration changes
  • If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

Related PRs

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

  • The problem being solved by the feature or fix is clear.
  • There is clarity on how the change or fix will impact the end user.
  • It is clear that the change will not negatively impact users or other areas of the platform.
  • The change is implemented comprehensively.
  • Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/
@github-actions
Copy link

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

@jmakowski1123 jmakowski1123 moved this to Product Pull Requests in Open edX Roadmap Feb 22, 2023
@jmakowski1123
Copy link
Author

Information from the original PR:

Current state of the feature

Initially, this feature used the Notifier Django app but was deprecated and removed from the configuration in favor of edx-notifications. More info about this deprecation can be found in the GitHub issue.

The edx-notifications app was not supported though, so its repository was archived and moved to GitHub - openedx-unsupported/edx-notifications. Check the deprecation ticket and corresponding discussion for details.

What remains in the edx-platform

The forum's initial page contains the how-to info with the notification preferences toggle:
image

This section is responsible for toggling the "notification_pref" user preference (aka NOTIFICATION_PREF_KEY). I didn't find any usage of this preference across the platform, so I'm suggesting hiding it by default by setting the ENABLE_FORUM_DAILY_DIGEST setting default value to False.

The result will look like
image

@jmakowski1123
Copy link
Author

Needs a product review from Aamir:

Can you confirm that "notification_pref" is not used anywhere across the platform?
Do the new Discussion Forum enhancements (BD-38) change the assumptions in this PR?
Are there considerations in light of the platform notifications work that should be taken into account?

@jmakowski1123 jmakowski1123 moved this to Roadmap Feature Tickets (Product) in Contributions Mar 1, 2023
@jmakowski1123
Copy link
Author

Aamir approved openedx/edx-platform#31459 (comment)

@jmakowski1123
Copy link
Author

@mphilbrick211 just wanted to confirm that you saw the "done" status of this one?

@jmakowski1123 jmakowski1123 moved this to Review done in Product Review Tracking Oct 19, 2023
@jmakowski1123 jmakowski1123 moved this from Feature Tickets - Product Pull Requests to [Prod Review] Done in Open edX Roadmap Mar 7, 2024
@jmakowski1123 jmakowski1123 moved this from [PR Review] Done to Shipped in Open edX Roadmap Mar 28, 2024
@jmakowski1123 jmakowski1123 added product review complete PR has gone through product review and removed product review done labels Mar 28, 2024
@sarina
Copy link
Contributor

sarina commented Jun 4, 2024

Closing as this is marked "Shipped" on the PR board 🎉

@sarina sarina closed this as completed Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Roadmap Feature Tickets (Product) to Done in Contributions Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product review complete PR has gone through product review
Projects
Archived in project
Status: Shipped
Status: Review done
Development

No branches or pull requests

2 participants