Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: MFE environment variable config #193

Open
davidjoy opened this issue May 25, 2023 · 0 comments
Open

[DEPR]: MFE environment variable config #193

davidjoy opened this issue May 25, 2023 · 0 comments
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@davidjoy
Copy link

davidjoy commented May 25, 2023

Proposal Date

2023-05-23

Target Ticket Acceptance Date

2023-06-06

Earliest Open edX Named Release Without This Functionality

Redwood - 2024 - 04

Rationale

MFE environment variable config is notoriously inflexible and brittle. It only accept strings, which severely limits the expressiveness and approachability of configuring an MFE. The community-supported release via Tutor does not use this config - it relies on runtime config. Further, we're about to add JS file config for those who still use build-time config, which is much more flexible. MFE env variable config should be removed.

⚠️ Note: I'm still fleshing out the required steps, which will affect the Removal, Replacement, Deprecation, and Migration steps below. ⚠️

Removal

Stub:

https://github.com/openedx/frontend-platform/blob/master/src/config.js#L42

This business here, where we use process.env to get values for our MFE config. We'd also remove all the .env files in all MFEs, and support for the DotEnv plugin in frontend-build.

Replacement

Stub: We'll be replacing .env config with js files, which are much more flexible and expressive

Deprecation

Stub: We plan to include build-time deprecation warnings which will need to be added to frontend-build.

Migration

Stub: Migration will need to start with Tutor and any other deployment methods, making them flexible enough to accept a JS file instead of a .env file for setting configuration. Once they can handle the new format, we can start cutting MFEs over.

Additional Info

@davidjoy davidjoy added the depr Proposal for deprecation & removal per OEP-21 label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Proposed
Development

No branches or pull requests

1 participant