Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal readme to npm packages with rst readmes #215

Open
30 tasks
brian-smith-tcril opened this issue Aug 14, 2023 · 2 comments
Open
30 tasks

add minimal readme to npm packages with rst readmes #215

brian-smith-tcril opened this issue Aug 14, 2023 · 2 comments

Comments

@brian-smith-tcril
Copy link

brian-smith-tcril commented Aug 14, 2023

Currently, repos with rst readmes that are published to npm appear without a readme

image

https://www.npmjs.com/package/@edx/frontend-build

Since NPM doesn't support RST, we should use Markdown READMEs in those repositories. See this documentation decision for more details on why.

Once openedx/openedx-atlas#39 is resolved we will have a pattern to follow for other repos that have this issue.

Tasks

  • For all repos that publish to NPM, convert their READMEs to Markdown
  • For all MFEs that will be published to NPM, convert their READMEs to Markdown

Relevant Repos

Note: This list might need to be refreshed if the time between this being written and it being picked up is more than a few weeks.

Currently Published to NPM

Preview Give feedback

MFEs that will be published in the Future

Preview Give feedback

Acceptance Criteria

  • The READMEs for all MFEs and repos currently published to NPM are in Markdown format.
  • All currently published packages have be re-published so that the new READMEs are visible on npmjs.org.
@OmarIthawi
Copy link
Member

Copying my comment from openedx/openedx-atlas#39.

@brian-smith-tcril Based on my quick research, it looks like that npm doesn't support RST at all, while PyPi appears to support both RST and Markdown:

Popular packages such as React.js use Markdown: https://www.npmjs.com/package/react

Some Open edX packages uses Markdown as well such https://www.npmjs.com/package/@edx/paragon while others don't as you pointed out for frontend-build.

We have a couple of options:

  1. Use Markdown on all Open edX Nodej.s packages
  2. Use Placeholder README (my least favorite)
  3. Convert to Markdown on the fly (adds yet one more build step)

I'm leaning towards using Markdown at least until npmjs has support for RST.

I understand that RST is generally more powerful and concise (while Markdown can be flaky sometimes). However, it's helpful to see the full README within npmjs.

If popular packages like React.js and paragon can get away with Markdown, I believe other npm-published packages can.

I remember a decision to push for RST documentation, which is a good format for Sphinx docs and python tools but it seems that npmjs decides to keep it unsupported so it seems to worth a double check.

@brian-smith-tcril
Copy link
Author

I did a search for all npm packages in the @edx org

repo markdown readme rst readme
@edx/paragon ✔️
@edx/studio-frontend ✔️
@edx/new-relic-source-map-webpack-plugin ✔️
@edx/gradebook ✔️
@edx/frontend-app-gradebook ✔️
@edx/eslint-config ✔️
@edx/frontend-lib-content-components ✔️
@edx/frontend-component-header ✔️
@edx/frontend-logging ✔️
@edx/frontend-analytics ✔️
@edx/frontend-enterprise ✔️
@edx/edx-bootstrap ✔️
@edx/edx-proctoring ✔️
@edx/frontend-component-site-footer ✔️
@edx/frontend-build ✔️
@edx/frontend-component-header-edx ✔️
@edx/frontend-auth ✔️
@edx/frontend-component-site-header ✔️
@edx/frontend-i18n ✔️
@edx/frontend-enterprise-catalog-search ✔️

I also know we plan to publish MFEs on npm, which would require moving those over to md too

repo markdown readme rst readme
frontend-app-learner-dashboard ✔️
frontend-app-learner-portal-enterprise ✔️
frontend-app-publisher ✔️
frontend-app-admin-portal ✔️
frontend-app-gradebook ✔️
frontend-app-program-console ✔️
frontend-app-learner-portal-programs ✔️
frontend-app-shell ✔️
frontend-app-programs-dashboard ✔️
frontend-app-authn ✔️
frontend-app-course-authoring ✔️
frontend-app-ora ✔️
frontend-app-library-authoring ✔️
frontend-app-account ✔️
frontend-app-discussions ✔️
frontend-app-ecommerce ✔️
frontend-app-payment ✔️
frontend-app-learning ✔️
frontend-app-enterprise-public-catalog ✔️
frontend-app-profile ✔️
frontend-component-footer ✔️
frontend-template-application ✔️
frontend-app-support-tools ✔️
frontend-app-learner-record ✔️
frontend-app-communications ✔️
frontend-app-ora-grading ✔️

based on this, it seems moving to md is non-trivial but not impossible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants