Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability by adding descriptions, tooltips, markdown, etc to dashboards and charts #169

Closed
Ian2012 opened this issue Jul 10, 2023 · 9 comments
Assignees
Labels
enhancement Relates to new features or improvements to existing features good first issue A good task for a newcomer to start with

Comments

@Ian2012
Copy link
Contributor

Ian2012 commented Jul 10, 2023

Currently, dashboards are shown up without any content other than the dashboard title. We need to improve readability and usability by adding more verbosity anywhere in the superset app

@Ian2012 Ian2012 added the good first issue A good task for a newcomer to start with label Jul 10, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Jul 10, 2023

Just a note that this should be localized as well.

@Ian2012 Ian2012 changed the title Improve usability by adding descriptions, tooltips, markdown, etc to dashboards Improve usability by adding descriptions, tooltips, markdown, etc to dashboards and charts Jul 10, 2023
@felipemontoya
Copy link
Member

I think that having a descriptive text "for humans" of what the data in the dashboard says would help a lot.
I've noticed that when I get to superset I end up asking @Ian2012 what the charts mean. Sometimes is obvious, but not everytime.

I thought using the markdown component should be easy but potent enough. I don't know how easy it would be to localize the content of said componenth though.

@sagar-manprax
Copy link
Contributor

I did some research and testing on this. I found out that Superset doesn't allow us to add slice_description in the YAML file that we import.

What I think could be a possible approach to do this is to make changes to the load-xapi-test-data command but that doesn't feel intuitively right.

Any suggestions on how else can we achieve this?

@Ian2012 Ian2012 added the enhancement Relates to new features or improvements to existing features label Aug 25, 2023
@bmtcril
Copy link
Contributor

bmtcril commented Sep 12, 2023

I think we can move this forward now. A few notes- we can add fields to the translation script for extraction. I think we should add X and Y labels, as well as chart descriptions to start.

In the chart yaml, when they are set, the following values exist:

slice_name: Grade distribution - courses
description: The distribution of grades for a course, out of 100%. Grades are bucketed
  in ranges of 10%.
...
params:
...
  y_axis_label: Number of Learners
...
  x_axis_label: Grade out of 100%
...

We should be able to mark those fields for translation, for instance here:

strings.append(asset["slice_name"])

We should also expand descriptions by default. We should be able to mark that at the dashboard level by setting:

"expand_slices": {"<slice_id>": true} see here: apache/superset#18347

@pomegranited
Copy link
Contributor

@bmtcril Thanks for showing me the "chart description" text -- I agree that's the best we can do for documenting charts.

But instead of hiding Help links in there, we could put help links/markdown into the dashboards -- this would be more visible, and could be a first port of call for people trying to find out more about the charts in a dashboard?

@bmtcril
Copy link
Contributor

bmtcril commented Oct 12, 2023

@pomegranited I've been trying to use text on the dashboards sparingly, since there's no way to dismiss it and it will largely be clutter after the first couple of times someone reads it, but I think help links back to Aspects docs for the dashboards / charts would be a great use of that space. There's even a place set aside for that documentation: https://github.com/openedx/openedx-aspects/tree/main/docs/reference

@pomegranited
Copy link
Contributor

@bmtcril That's excellent -- could I tackle building out this documentation and deep-linking to it from the various dashboards and charts?

@bmtcril
Copy link
Contributor

bmtcril commented Oct 26, 2023

That would be great! There are some thoughts that operators may want to hide those links with a feature flag, but I think we can add that later if need be.

@bmtcril
Copy link
Contributor

bmtcril commented Nov 17, 2023

I think we can call this done, it will likely need iteration based on user feedback but we have all the tools necessary to make this work really well now 👍

@bmtcril bmtcril closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features good first issue A good task for a newcomer to start with
Projects
None yet
Development

No branches or pull requests

5 participants