Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update readme to include building Superset image #577

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Jan 29, 2024

Without this step we no longer create the correct assets, and Superset is full of errors.

@bmtcril bmtcril marked this pull request as ready for review January 29, 2024 17:11
@bmtcril bmtcril requested a review from Ian2012 January 29, 2024 17:11
@bmtcril
Copy link
Contributor Author

bmtcril commented Jan 29, 2024

@Ian2012 I think that we do not need to build the aspects image, but I can add that if I'm wrong.

@Ian2012
Copy link
Contributor

Ian2012 commented Jan 29, 2024

@bmtcril there is no need to build the Aspects image

@Ian2012 Ian2012 merged commit 5d69ce2 into main Jan 29, 2024
6 checks passed
@Ian2012 Ian2012 deleted the bmtcril/update_readme branch January 29, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants