Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] <TC_AUTHOR_86> Inconsistent Behavior with 'Hide Discussion Tab' Toggle and Discussion Sidebar Accessibility #417

Closed
HeliaEnayati opened this issue Nov 16, 2024 · 4 comments
Assignees
Labels
release testing Affects the upcoming release (attention needed) sumac

Comments

@HeliaEnayati
Copy link

HeliaEnayati commented Nov 16, 2024

Release

sumac

Expected behavior

When the 'Hide Discussion Tab' toggle is enabled and saved, the interface should reflect this change without requiring a refresh of the Page and Resources page. Clarification is needed on the expected behavior regarding the sidebar's accessibility when the discussion tab is hidden.

Actual behavior

  1. After enabling the "Hide Discussion Tab" toggle and clicking "Save," you are redirected back to the Page and Resources page. Up to this point, everything is functioning and the discussion tab will be hidden as expected.

  2. The "Enabled" label remains on the discussion card until the page is refreshed

  3. In the course outline, the unit discussion configuration settings relating to the discussion sidebar can still be checked or unchecked, but this does not result in any changes. I understand that enabling the 'Hide Discussion Tab' toggle prevents learners from posting in the discussion forums. However, I think enabling the 'Hide Discussion Tab' toggle should either disable the ability to make changes to the unit discussion configuration or allow learners to see the sidebar but not post in it. This inconsistency in labels may confuse the instructor.

Steps to reproduce

  1. Log in to the studio
  2. Navigate to the Page and Resources section.
  3. Click on the configure icon and enable the "Hide Discussion Tab" toggle.
  4. Click "Save" and observe the behavior on the Page and Resources page regarding the "Enabled" label.
  5. Refresh the page and note any changes in the label's visibility.
  6. Check the course outline and unit cards to see if the discussion status reflects the toggle changes.

Additional information

No response

@HeliaEnayati HeliaEnayati added needs triage release testing Affects the upcoming release (attention needed) labels Nov 16, 2024
@HeliaEnayati HeliaEnayati changed the title [Test failure] Inconsistent Behavior with 'Hide Discussion Tab' Toggle and Discussion Sidebar Accessibility [Test failure] <TC_AUTHOR_86> Inconsistent Behavior with 'Hide Discussion Tab' Toggle and Discussion Sidebar Accessibility Nov 16, 2024
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Dec 2, 2024

Thank you for the report!

The hide discussion tab doesn't disable the discussions service altogether, it seems to be that just hides the tab for learners, as the confirmation message says:

The discussion tab will no longer be visible to learners in the LMS. Additionally, posting to the discussion forums will be disabled. Are you sure you want to proceed?

Hiding the discussion tab didn't remove the enable chip even after reloading for me. I had to do some maneuvers in the Django admin to make it disappear. Your report is pretty detailed and thorough, so thank you for that. But can you confirm again that the enable chip disappeared after reloading? Cause I can't reproduce it.

I believe the configuration from Pages & Resources only affects course-wide settings. It hides the course discussion tab in the LMS and configures the discussion provider, but it doesn't disable the discussion service per se, so in-line discussions are still available.

I can't find anything in the docs explicitly saying how to disable discussions altogether besides setting FEATURES["ENABLE_DISCUSSION_SERVICE"] = False in the sandbox environment.

Please, let me know if I’m wrong about any of this.

@mariajgrimaldi
Copy link
Member

@crathbun428: could you give us a hand with? Clarification is needed on the expected behavior regarding the sidebar's accessibility when the discussion tab is hidden.

I can't find any docs about this anywhere, maybe I'm missing something.

@mariajgrimaldi mariajgrimaldi self-assigned this Dec 2, 2024
@crathbun428
Copy link

@mariajgrimaldi - your read of how this works sounds right to me: The configuration from Pages & Resources only affects course-wide settings. It hides the course discussion tab in the LMS and configures the discussion provider, but it doesn't disable the discussion service per se, so in-line discussions are still available.

@mariajgrimaldi
Copy link
Member

@crathbun428 thank you! I'm going to close this since it is a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed) sumac
Projects
Development

No branches or pull requests

3 participants