Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_AUTHOR_50: The zooming tool image is not working properly #421

Closed
DeimerM opened this issue Nov 19, 2024 · 5 comments · Fixed by openedx/edx-platform#36012
Assignees
Labels
release testing Affects the upcoming release (attention needed) sumac

Comments

@DeimerM
Copy link

DeimerM commented Nov 19, 2024

Release

Sumac

Expected behavior

it expects the image to zoom in on the relevant parts when hovered over.

Actual behavior

Nothing happens when hovering over the image, and we're getting an error in the developer console. We've even tried downloading the JS file, uploading it to the course, and configuring the new URL, but we're still getting the same error.

Steps to reproduce

  1. Add a component of the type zooming tool image.
  2. Try to hover over the image to ensure that it is zooming.
  3. Open the developer tools console to discover the error.

Additional information

Screenshot From 2024-11-14 11-30-13

@DeimerM DeimerM added needs triage release testing Affects the upcoming release (attention needed) labels Nov 19, 2024
@mariajgrimaldi
Copy link
Member

Duplicate of #381

@mariajgrimaldi mariajgrimaldi marked this as a duplicate of #381 Nov 22, 2024
@mariajgrimaldi
Copy link
Member

Thank you for the report! This is currently being worked on in the issue I linked above :)

@mariajgrimaldi
Copy link
Member

Here's the PR for the fix: openedx/edx-platform#35661

@mariajgrimaldi mariajgrimaldi self-assigned this Nov 25, 2024
@arbrandes
Copy link
Contributor

The PR fixes loading of the script, but the script itself is broken. The correct solution to supporting this doesn't exist yet, and certainly won't exist in time for Sumac.1, so if this is really a blocker, we should just remove the tool from the sumac.master branch until a better way is found.

@arbrandes
Copy link
Contributor

arbrandes commented Dec 9, 2024

We're no longer considering this a release blocker, but in any case, the DEPR was accepted and the template removed from master. All that's left is the Sumac backport:

openedx/edx-platform#35998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed) sumac
Projects
Development

Successfully merging a pull request may close this issue.

4 participants