-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test failure] TC_AUTHOR_110: Certificate available date not working #429
Comments
@mariajgrimaldi i was able to check this |
I used the student account in the sandbox and this course: https://apps.sumac.demo.edly.io/learning/course/course-v1:Test+test_cert+2024/dates, which I'm guessing is the same one used during this test. I see the correct date in the dates section: But the course status is less accurate, saying the certificates will be available after the course ends but with no specific date: Sometimes changes take a while to be reflected in the LMS, so maybe that's what happened during the test. I also tested with a new student, and I can see that the dates I mentioned are displayed. I played around a bit more and generated an honor certificate through the Django admin (the enrollments of these users are in audit mode, so no certificate would be generated as far as I understand), then here's what I see in the certificate status section: |
If I'm reading this correctly, there is never incorrect information being communicated. Either we say after course end date or after exact date. Both of which are accurate. I agree this is a bug that should be addressed, but I don't think this rises to the level of a release blocker. @mariajgrimaldi, @angonz, @AntonellaPerrupato - do any of you disagree? I can be swayed, but this would be my read of the situation. |
The reason is that the certificate data in the courseware api is None if the user didn't earn a certificate. This is processed by the get_cert_data function in edx-platform. If the user didn't get a certificate yet, then the Progress page will display the course end date instead, as the course metadata does not contain the certificate available date. When the user has a certificate, although it's not available yet, there is a certificate data in the course metadata which includes the certificate available date. I agree that the information displayed is not incorrect. Although it would be disappointing for a student to take a course expecting my certificate by the course end date, and then after earning it, being informed that it will be available days after. Moreover, the actual certificate available date is known and does not depend on the student, so I don't see the point of hiding it. Overall, I think that the whole certificate workflow should be revised as it is very cumbersome... |
Thanks, @crathbun428! I agree this should be addressed somehow. Can we clarify the correct behavior in this case? Thank you, @angonz, for the thorough explanation! That'd give us a sense of where to look once we start addressing this behavior. |
@mariajgrimaldi - wait - am I reading it right that the correct dates appear when you log in as a learner? If so, I would say nothing needs to be fixed here? What am I missing? @angonz |
No, the information is correct only in the Dates page. In the Progress page it's the same. No matter if you log in as student or staff. |
Release
Sumac
Expected behavior
Certificates should be available on the selected date, after the course end date
Actual behavior
Certificates are made available after the course end date.
Steps to reproduce
Work on an instructor-paced course. Enable the certificates.auto_certificate_generation waffle switch.
In Studio, Settings, Schedule and Details, set a course end date.
Set "Certificate display behavior" to "A date after the course end date".
Set "Certificate available date" to a date after the end date. Save.
Go to the LMS. Complete the tests to get a passing grade.
In the progress page you should see a message "Certificate status. Final grades and any earned certificates are scheduled to be available after ..."
The date informed should be the date set under "Certificate available date".
Additional information
No response
The text was updated successfully, but these errors were encountered: