Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metadata db to 2023 and updated tests/snapshots accordingly #83

Merged
merged 4 commits into from
May 25, 2023

Conversation

ssuffian
Copy link
Contributor

@ssuffian ssuffian commented May 12, 2023

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a feature/bugfix branch (right side). Don't request your master!
  • Make sure tests pass and coverage has not fallen docker-compose run --rm test.
  • Update the CHANGELOG.md to describe your changes in a bulleted list under the "Development" section at the top of the changelog. If this section does not exist, create it.
  • Make sure code style follows PEP 008 using docker-compose run --rm blacken.
  • Make sure that new functions and classes have inline docstrings and are
    included in docs/api.rst for the sphinx build. Please use numpy-style docstrings.
    Sphinx docs can be built with the following command: docker-compose run --rm --entrypoint="make -C docs html" shell. Please note and fix any warnings.
  • Make sure that all git commits are have the "Signed-off-by" message for
    the Developer Certificate of Origin. When you're making a commit, just add
    the -s/--signoff flag (e.g., git commit -s).

Description

This PR fixes the issues referenced in #81, #67, and #59.

The tmy3-stations.html file is now stored within the package, and the CA climate zone link has been updated. The metadata.db has been rebuilt and now uses 2023 data for calculate quality.

ssuffian added 3 commits May 12, 2023 10:30
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
@ssuffian ssuffian assigned ssuffian and unassigned ssuffian May 12, 2023
@jason-recurve
Copy link
Contributor

LGTM, might want to include two notes in the changelog for the shapely containment fix and adding db removal to the rebuild command

Signed-off-by: Stephen Suffian <[email protected]>
@ssuffian
Copy link
Contributor Author

Updated.

@jason-recurve jason-recurve merged commit 6aae9cf into master May 25, 2023
@ssuffian ssuffian deleted the feature/update-metadata-to-2023 branch January 14, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants