Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding python3-fastapi and python3-fastapi-debian to the templates
Description
It would be awesome to have the fastapi templates in the main repo. I used https://github.com/loudsquelch/openfaas-python3-fastapi-template for my additions and created an alpine and debian version similar to the python3 ones you are providing.
Motivation and Context
The default python3 module is okayish, but with fastapi we can have the advantages of that library in openfaas. I have specified workers 1 to leave the scaling up to openfaas. The /doc route should be exposed as usual and all in all it should provide a better way of integrating APIs with OpenFAAS.
Which issue(s) this PR fixes
How Has This Been Tested?
I deployed both functions to my local OpenFAAS setup and ran the
./verify.sh
scriptTypes of changes
Impact to existing users
Two new templates are added that do not change the existing python3 and python3-debian templates
Checklist:
git commit -s