Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for every edge cases. #88

Open
sumit-158 opened this issue Jan 21, 2023 · 10 comments
Open

Increase test coverage for every edge cases. #88

sumit-158 opened this issue Jan 21, 2023 · 10 comments
Assignees
Labels
✨ enhancement New feature or request 🏄‍♂️ good first issue Good for newcomers

Comments

@sumit-158
Copy link
Member

Problem

We have fewer tests coverage for "data_quality_kp", "last_edits_kp" and "wikidata_kp"

Proposed solution

  • Add relevant tests case for all these panels, you can take inspiration from Hunger game test cases here.
  • Also it would be better if we separate all these tests into their specific file like "hunger-game" which can be stored in "test_hunger_game.py" and so on.
@sumit-158 sumit-158 added ✨ enhancement New feature or request 🏄‍♂️ good first issue Good for newcomers labels Jan 21, 2023
@sumit-158 sumit-158 changed the title feat: Increase test coverage for every edge cases. Increase test coverage for every edge cases. Jan 21, 2023
@mahak24342
Copy link

i wanna take up this issue , please assign me this issue

@sumit-158
Copy link
Member Author

Sure @mahak24342 , Please do it :-)

@sarayusreeyadavpadala
Copy link
Contributor

Hi @sumit-158 I am a beginner and interested to take a part in solving this issue. Could you help me?

@sumit-158
Copy link
Member Author

Sure, @sarayusreeyadavpadala in test_knowledge_panels.py we have test cases for hungergame but a few test cases for other panels "last_edits" ....
We want to add more test cases for those panels.

@sarayusreeyadavpadala
Copy link
Contributor

@sumit-158 How can I do this?

@sarayusreeyadavpadala
Copy link
Contributor

@sumit-158 Could you explain more about these panels (last_edits_kp, wikidata_kp, data_quality_kp)?

@sumit-158
Copy link
Member Author

sumit-158 commented Sep 4, 2023

@sumit-158 Could you explain more about these panels (last_edits_kp, wikidata_kp, data_quality_kp)?

These are functions that are used to fetch data from OpenFoofFacts API.

How can I do this?

Just look for current hunger games tests and replicate them for other panels ( If they don't have that)

@sarayusreeyadavpadala
Copy link
Contributor

Just look for current hunger games tests and replicate them for other panels ( If they don't have that)

Okay @sumit-158

@sarayusreeyadavpadala
Copy link
Contributor

These are functions that are used to fetch data from OpenFoofFacts API.

Thanks for your reply @sumit-158

@sarayusreeyadavpadala
Copy link
Contributor

@sumit-158 Please assign me this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 🏄‍♂️ good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants