Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the "user search" query method from smoothie #488

Closed
monsieurtanuki opened this issue Jun 20, 2022 · 0 comments · Fixed by #499
Closed

Move the "user search" query method from smoothie #488

monsieurtanuki opened this issue Jun 20, 2022 · 0 comments · Fixed by #499
Assignees
@monsieurtanuki

Comments

@monsieurtanuki
Copy link
Contributor

A new search method was recently created in Smoothie

That method is related to the user history, like "all the products this user edited".

When the code in Smoothie is stabilized, the method should be moved here.
@monsieurtanuki monsieurtanuki self-assigned this Jun 22, 2022
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Jun 26, 2022
@monsieurtanuki
feat: openfoodfacts#488 - new user-related queries
e0a8803 
New files:
* `api_getUserProducts_test.dart`: tests around `UserProductSearchQueryConfiguration`
* `UserProductSearchQueryConfiguration.dart`: Query Configuration for user-related searches.

Impacted file:
* `openfoodfacts.dart`: new generic method `getProducts`; refactored
@monsieurtanuki monsieurtanuki mentioned this issue Jun 26, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jun 29, 2022
@monsieurtanuki
feat: #488 - new user-related queries (#499)
1ee5184 
New files:
* `api_getUserProducts_test.dart`: tests around `UserProductSearchQueryConfiguration`
* `UserProductSearchQueryConfiguration.dart`: Query Configuration for user-related searches.

Impacted file:
* `openfoodfacts.dart`: new generic method `getProducts`; refactored
@github-actions github-actions bot mentioned this issue Jun 29, 2022
Merged
@monsieurtanuki monsieurtanuki mentioned this issue Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #488 - new user-related queries monsieurtanuki/openfoodfacts-dart
1 participant
@monsieurtanuki