Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the product URL editing from V1 #2738

Open
2 tasks
Tracked by #503
teolemon opened this issue Aug 6, 2022 · 14 comments
Open
2 tasks
Tracked by #503

Reintroduce the product URL editing from V1 #2738

teolemon opened this issue Aug 6, 2022 · 14 comments
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers P3

Comments

@teolemon
Copy link
Member

teolemon commented Aug 6, 2022

What

  • Reintroduce the product URL editing from V1
  • This is low priority - a good candidate for "good first issue"

Image

Part of

@M123-dev
Copy link
Member

M123-dev commented Aug 7, 2022

When I understand it correct allow to search for full urls or what is this issue about

@teolemon
Copy link
Member Author

teolemon commented Aug 7, 2022

It allows to search for full url using 2 options, in the case of Google Search, you have to copy paste it, in the case of a qr code, it's filled automatically

@teolemon
Copy link
Member Author

image

@monsieurtanuki
Copy link
Contributor

"QR code scan" is a "good first issue"? Glad to hear that! ;)
At least I can imagine what it's all about.

But for the "search" button I have no idea what it's supposed to do. Open an external "google search" web window with the barcode / product name?

@anujchoudhary-17
Copy link
Contributor

@teolemon Can I work on this as this issue is not assigned to anyone yet ?

@teolemon
Copy link
Member Author

You are assigned @anujchoudhary-17 👍

@g123k
Copy link
Collaborator

g123k commented May 22, 2023

@teolemon Can I work on this as this issue is not assigned to anyone yet ?

By curiosity, how do you want to implement it?

@anujchoudhary-17
Copy link
Contributor

os
Hi, @g123k @teolemon This is the current look of the page. Could you please give me a proper UI of the page or guide me on how you want it? I am a bit confused
Thank you :)

@g123k
Copy link
Collaborator

g123k commented May 24, 2023

Just open a product, click on Edit and go to the bottom of the page

@teolemon
Copy link
Member Author

Screenshot_20230526-123053.png

Screenshot_20230526-123043.png

Screenshot_20230526-123027.png

@teolemon teolemon added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label May 26, 2023
@anujchoudhary-17
Copy link
Contributor

WhatsApp.Video.2023-06-02.at.11.23.33.PM.mp4

Hi @teolemon and @g123k, Could you please guys take a look at this I made the feature it is not completed yet. But please guide me a little about the "Search for official page URL" button. What is the purpose of it will it navigate the user to the link which is filled in the text field?

Thank you, Sorry for being not much active on this for last week

@teolemon
Copy link
Member Author

teolemon commented Jun 3, 2023

We could take the whole width of the screen for each button, and use the standard button, but we risk confusion with the save button

@anujchoudhary-17
Copy link
Contributor

anujchoudhary-17 commented Jun 3, 2023

We could take the whole width of the screen for each button, and use the standard button

Can we quickly connect for 2 mins on google meet if you have time right now? Need some clarification on this task

@teolemon
Copy link
Member Author

teolemon commented Jun 3, 2023

yes of course: https://meet.google.com/gnp-frks-esc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers P3
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

5 participants