cube endpoints do not specify a coords parameter

[tomkralidis]

Describe the bug
Testing https://demo.pygeoapi.io/master yields an error in the Collections conformance class (cubeCoordsParameterDefinition)

The error from CITE reads:

Required coords parameter for collections with path '/cube' in OpenAPI document is missing expected object to not be null

As per 19-086r6, 8.2.4, an EDR cube query does not specify or require the coords parameter, but bbox instead.

To Reproduce
Test https://demo.pygeoapi.io/master against https://cite.opengeospatial.org/teamengine

Expected behavior
The test should not check for the existence of a coords parameter for the following query types:

• cube
• items
• locations

Screenshots

Additional context
None

[dstenger]

Thanks for reporting.

This issue was already reported #112 and fixed.

Beta environment contains an installation of that fix (it has not been moved to Production, yet): https://cite.ogc.org/te2/

The test was renamed to cube Bbox Parameter Definition .

I tested your service and get a different error:

cube Bbox Parameter Definition

Expected property 'required' with value 'true' but was 'false'

Can you please check your service regarding this?

Still, we (CITE team) need to check if

• items
• locations

must also be adjusted.

Side note: You are referencing the spec of version 1.1. However, this test suite is only suitable for version 1.0.

[tomkralidis]

Thanks @dstenger. I've made some local changes which fix the bbox issue, thanks.

I now see the below issue (6 times), any idea?

[tomkralidis]

Still, we (CITE team) need to check if

• items
• locations

must also be adjusted.

Mea culpa. locations does not require a bbox query parameter.

[dstenger]

Thanks for the feedback.

Can you please create a new issue for error detected in #130 (comment) as it seems to be a different issue? By viewing your screenshot, I unfortunately do not have an idea what is going wrong here.

Thanks for the clarification in #130 (comment). We will still check if any adjustments must be made for "items".

[tomkralidis]

Thanks for the feedback.

Can you please create a new issue for error detected in #130 (comment) as it seems to be a different issue? By viewing your screenshot, I unfortunately do not have an idea what is going wrong here.

Done in #131

Thanks for the clarification in #130 (comment). We will still check if any adjustments must be made for "items".

Thanks!

[dstenger]

items are currently not tested by the test suite.
We checked the specification (version 1.0.0) and would expect items tests in B.10. Conformance Class Queries. However, there is no abstract test defined for this conformance class.
FYI: We also checked version 1.1 of the specification and it seems that items are tested there. Unfortunately, there is currently no test suite for this version.

If you do not have any further questions, I propose to close the issue.