Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests performance #183

Closed
jerstlouis opened this issue Nov 9, 2021 · 4 comments
Closed

Improve tests performance #183

jerstlouis opened this issue Nov 9, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jerstlouis
Copy link
Member

jerstlouis commented Nov 9, 2021

Is your feature request related to a problem? Please describe.
Executing the tests on our implementation takes a good 30 minutes even when testing only 3 collections.
I don't think it is because of processing or data transfer time on our end. It is also a lot more time than the sum of the duration of the tests, most of which are under 1s except for 4 that take up to ~1min30s. Opened a separate issue (#182) about the lack of progress indicator during that time, which originally had me think the tests were stuck.

Describe the solution you'd like
The tests should complete relatively quickly, in about the amount currently reported in the test report.

@dstenger
Copy link
Contributor

dstenger commented Nov 9, 2021

Thank you for reporting.

This problem is most likely related to the number of features provided by the collections.

@dstenger dstenger added the enhancement New feature or request label Nov 9, 2021
@jerstlouis
Copy link
Member Author

jerstlouis commented Nov 9, 2021

Thank you @dstenger .
I believe the test uses the first 3 listed vector collections on our server which are:

NaturalEarth:cultural:ne_10m_admin_0_boundary_lines_maritime_indicator (220 features, items: 236kb)
NaturalEarth:cultural:ne_10m_admin_0_antarctic_claims (10 features, items: 462kb)
NaturalEarth:cultural:ne_10m_admin_0_sovereignty (206 features, items: 20.8 mb, response+download time for all 206 features is ~40s)

I wouldn't consider this a large number of features -- we are planning to eventually host the full 60+GB Planet OpenStreetMap dataset which has over a billion features.

Ideally the tests should work without requesting every single feature and/or otherwise allow the user to explicitly list collections of a reasonable size to test.

The issue might be processing the sovereignty as it contains a significant bit of geometry. This highlights the importance of a geometry simplification / clipping capability.

Regardless, the current responses should be manageable in a lot less time.

@dstenger
Copy link
Contributor

dstenger commented Jun 1, 2023

@jerstlouis We cannot reproduce the test run of 30 minutes anymore. However, we agree that the performance can be improved. Issue #202 was created to improve the performance of the test suite.
If you agree, I propose to close this issue.

@jerstlouis
Copy link
Member Author

jerstlouis commented Jun 1, 2023

Thanks @dstenger . Closing. I will reopen with more details if I run into a similar 30 minutes wait again.

What would be really great is to have a continuously updating log visible to the user in the client window of which requests are being sent to the server.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants