Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbox schema test is outdated #223

Open
cportele opened this issue Aug 1, 2023 · 1 comment
Open

bbox schema test is outdated #223

cportele opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cportele
Copy link
Member

cportele commented Aug 1, 2023

Describe the bug
The test of the schema of the bbox parameter is outdated.

The current test requires

  type: array
  minItems: 4
  maxItems: 6
  items:
    type: number

but in version 1.0.1 this was updated to

  type: array
  oneOf:
  - minItems: 4
    maxItems: 4
  - minItems: 6
    maxItems: 6
  items:
    type: number

See https://docs.ogc.org/is/17-069r4/17-069r4.html#_parameter_bbox (vs https://docs.ogc.org/is/17-069r3/17-069r3.html#_parameter_bbox).

To support implementations of versions 1.0.0 and 1.0.1, the test should accept both variants.

To Reproduce
Review code and standard.

Expected behavior
Both schemas should be accepted by the tests.

Screenshots
n/a

Additional context
n/a

@dstenger dstenger self-assigned this Aug 1, 2023
@dstenger dstenger added the enhancement New feature or request label Aug 1, 2023
@dstenger
Copy link
Contributor

dstenger commented Aug 1, 2023

Thank you for reporting.

Currently, the test suite just supports version 1.0.0 (see linked specification on https://cite.ogc.org/te2/about/ogcapi-features-1.0/1.0/site/).
There is already an issue to support version 1.0.1 (#204) which is currently in our backlog.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to To do in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

4 participants