Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box numberMatched test failures due to loss of precision in extent coordinates #239

Open
code-akki opened this issue May 22, 2024 · 2 comments
Assignees

Comments

@code-akki
Copy link

Describe the bug
The precision of coordinates (> 7 decimals) returned in the actual extent of FeatureResponse is rounded off to 7 digits by the compliance test which leads to inconsistency in the response returned by the validateFeaturesWithBoundingBoxResponse_NumberMatched. The round off might be the consequence of this.

The extent returned in the featureResponse is (-7.557159806905192, 49.76680723514262, 1.112473832170855, 57.70488356766183) [see Parameter No. 1 in the image below] is rounded off to (-7.5571598,49.7668072,1.1124738,57.7048836) [see Parameter No. 2 in the image below]

The above issue is not the same as the one mentioned in #188, but rather due to the truncation of digits during a round-off. The missing points fall just outside the bounding-box because the extent is rounded-off.

To Reproduce
Steps to reproduce the behavior:

  1. Test against our test server

Expected behavior
NA

Screenshots
ogc_compliance_error_1

Additional context

@dstenger
Copy link
Contributor

Thank you for reporting.
We will do further investigation.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to To do in CITE Aug 1, 2024
@bpross-52n
Copy link
Contributor

@code-akki I used the following request, wich contains the bounding box taken from the collection metadata without any rounding of the coordinates:
https://ogc-compliance.iudx.io/collections/1e7f3be1-5d07-4cba-9c8c-5c3a2fd5c82a/items?bbox=-7.557159806905192%2C49.76680723514262%2C1.112473832170855%2C57.70488356766183
This returns 29994 features:

{
    "numberMatched": 29994,
    "features": [
        {
....

As the collection contains 30000 features and the extent from the collection metadata was used for the request, we would expect that all 30000 features are returned by this request. Would you agree to that?

@dstenger dstenger moved this from In progress to Waiting in CITE Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting
Development

No branches or pull requests

3 participants