Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTPS support for generated URL #73

Open
dstenger opened this issue Feb 1, 2024 · 4 comments
Open

Enable HTTPS support for generated URL #73

dstenger opened this issue Feb 1, 2024 · 4 comments
Assignees
Labels

Comments

@dstenger
Copy link
Contributor

dstenger commented Feb 1, 2024

Originally reported by @robinhoutmeyers in #68 (comment):

I also encountered a similar issue during a beta test for #66. Steps to reproduce:

=> although the test session console and the test results (after stopping the test) will recognize the fact that a GetCapabilities and GetMap requests were received, the display during the test is never updated.

@bpross-52n
Copy link
Contributor

Imho, this issue is related to mixed content served by Teamengine, i.e. mixed http/https content. We will update the Teamengine instances to provide only https content.

@bpross-52n
Copy link
Contributor

@dstenger It turns out that this can be solved via configuration of the proxy and Tomcat. A RemoteIpValve needs to be set in the server.xml so that the x-forwarded-proto hearder will be recognised by Tomcat, see here:
https://stackoverflow.com/questions/5741210/handling-x-forwarded-proto-header-in-java-web-application

I added the following line to the ets-wms-client13 docker file:

RUN sed -i 's|\
  </Host>|\
    <Valve className="org.apache.catalina.valves.RemoteIpValve" \
      remoteIpHeader="X-Forwarded-For" \
      protocolHeader="X-Forwarded-Proto"/>\
  </Host>|' \
  /usr/local/tomcat/conf/server.xml

This header needs to be set in the proxy to the respective protocol. I used this for nginx: proxy_set_header X-Forwarded-Proto $scheme;. If https is requested now it is used for the tests without any necessary modification of the code.

@dstenger
Copy link
Contributor Author

dstenger commented Jun 28, 2024

@robinhoutmeyers We updated the Beta environment. Can you please check if the problem still occurs?

@dstenger dstenger changed the title GetMap requests are not recognized by test suite Enable HTTPS support for generated URL Jul 25, 2024
@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to To verify in CITE Aug 1, 2024
@robinhoutmeyers
Copy link

This seems indeed fixed, thanks! Sorry for the late reply, I accidentally overlooked this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To verify
Development

No branches or pull requests

3 participants