-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of popups #4308
Comments
If I think for WEB clients, one question is: what size for the popup ? |
It should be smaller than the display width, so maybe one column less than the remain UI (but at least one, of course)?
Popups must not have any other popups or subpages. IMO that wouldn't be a good user experience. |
I agree with you but how do you garantee that ? By adding a complex control when loading the sitemap ? |
Can this checked by the Sitemap validator? The thing that refuses loading Sitemap files with invalid syntax. |
Yes, very probably but I am not sure that the check is easy to implement. |
Naming suggestion for the property: |
Is your feature request related to a problem? Please describe.
Sometimes I want a subpage in a Sitemap that only contains a few elements. In that case I'd like to be able to configure this subpage as popup as popups can be closed faster, e.g. by clicking anywhere outside the popup.
Example: In the page "Living Room" there's one one-line entry "TV" that opens a subpage with a
Buttongrid
containing a remote control. I don't want to add the remote control to the Living room page directly as it requires some space and is rarely used.Describe the solution you'd like
Add a new property
subpage
that controls the type of the subpage:subpage
(default) orpopup
. It can be added to all widgets that have subpages:Clients are free to implement this popup as popup or use bottom sheets as I would do on Android (https://m3.material.io/components/bottom-sheets/overview).
I'm not sure about the best name for that property.
Coordination between maintainers
Notify maintainers of other UIs:
@openhab/webui-maintainers
@openhab/android-maintainers
@openhab/ios-maintainers
Checklist for implementation:
The text was updated successfully, but these errors were encountered: