Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: use wrong utils to map platformid to platformname #207

Closed
CNCSMonster opened this issue Sep 18, 2023 · 3 comments
Closed

Bug: use wrong utils to map platformid to platformname #207

CNCSMonster opened this issue Sep 18, 2023 · 3 comments
Labels
bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@CNCSMonster
Copy link
Contributor

What happened?

in internal/chat/log.go:UploadLogs, using gorm/utils to map platform id to platformname
like Platform: utils.ToString(req.Platform),
but should use constant utils defined in openimsdk/protocol

What did you expect to happen?

using protocol/constant 's PlatformIDToName function to map id to name

How can we reproduce it (as minimally and precisely as possible)?

watch that code

Anything else we need to know?

No response

version

```console $ {name} version # paste output here ```

Cloud provider

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

@CNCSMonster CNCSMonster added the bug Categorizes issue or PR as related to a bug. label Sep 18, 2023
@CNCSMonster
Copy link
Contributor Author

no longer need

@kubbot
Copy link
Contributor

kubbot commented Nov 17, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kubbot kubbot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 25, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants