Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emailRegister check #308

Merged
merged 15 commits into from
Dec 18, 2023
Merged

Add emailRegister check #308

merged 15 commits into from
Dec 18, 2023

Conversation

AndrewZuo01
Copy link
Contributor

@AndrewZuo01 AndrewZuo01 commented Dec 15, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

#307 #309

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@AndrewZuo01 AndrewZuo01 requested review from cubxxw and a team as code owners December 15, 2023 04:23
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2023
Copy link

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

FGadvancer
FGadvancer previously approved these changes Dec 15, 2023
Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please consider adding unit tests to the code? It would greatly improve the overall quality and reliability of the software. Thank you for your attention to this matter.

@FGadvancer FGadvancer added this pull request to the merge queue Dec 18, 2023
Merged via the queue into openimsdk:main with commit 49822f9 Dec 18, 2023
21 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants