Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-docker-image.yml #312

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Update build-docker-image.yml #312

merged 4 commits into from
Dec 16, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 16, 2023


🔍 What type of PR is this?

/kind bug
/kind cleanup
/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

I have successfully resolved the issue with mapping the openim-chat image directory in docker compose, as well as addressed the configuration problem. Additionally, I have tackled some environment variable handling issues and modified the logic for githooks. Furthermore, I have optimized the versioning process for building the openim-chat image using GitHub actions.

🅰 Which issue(s) this PR fixes:

Fixes #313

📝 Special notes for your reviewer:

code review

🎯 Describe how to verify it

make init

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw cubxxw requested review from a team as code owners December 16, 2023 08:38
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2023
@cubxxw cubxxw enabled auto-merge December 16, 2023 08:38
Copy link

sweep-ai bot commented Dec 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: Xinwei Xiong (cubxxw) <[email protected]>
Signed-off-by: Xinwei Xiong (cubxxw) <[email protected]>
@pull-request-size pull-request-size bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2023
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

openimbot
openimbot previously approved these changes Dec 16, 2023
Signed-off-by: Xinwei Xiong (cubxxw) <[email protected]>
@cubxxw cubxxw added this pull request to the merge queue Dec 16, 2023
Merged via the queue into main with commit f04ad68 Dec 16, 2023
11 checks passed
@cubxxw cubxxw deleted the fix/fix-images branch December 16, 2023 10:01
@openimsdk openimsdk locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Optimize openim-chat Configuration Logic and Support make init Script Generation
3 participants