Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify component check #342

Merged
merged 4 commits into from
Dec 25, 2023
Merged

modify component check #342

merged 4 commits into from
Dec 25, 2023

Conversation

AndrewZuo01
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@AndrewZuo01 AndrewZuo01 requested review from cubxxw and a team as code owners December 25, 2023 03:54
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 25, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 25, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2023
@skiffer-git skiffer-git added this pull request to the merge queue Dec 25, 2023
Merged via the queue into openimsdk:main with commit 8d50804 Dec 25, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skiffer-git skiffer-git skiffer-git approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

@cubxxw cubxxw Awaiting requested review from cubxxw

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewZuo01 @FGadvancer @skiffer-git