Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove zk test tool and fix check_all #354

Merged
merged 9 commits into from
Dec 26, 2023
Merged

remove zk test tool and fix check_all #354

merged 9 commits into from
Dec 26, 2023

Conversation

AndrewZuo01
Copy link
Contributor

@AndrewZuo01 AndrewZuo01 commented Dec 26, 2023 •
edited
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #355

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@AndrewZuo01 AndrewZuo01 requested review from cubxxw and a team as code owners December 26, 2023 03:48
@pull-request-size Pull Request Size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 26, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@AndrewZuo01 AndrewZuo01 changed the title update ZK test remveo zk test tool and fix check_all Dec 26, 2023
@cubxxw cubxxw added this pull request to the merge queue Dec 26, 2023
@AndrewZuo01 AndrewZuo01 changed the title remveo zk test tool and fix check_all remove zk test tool and fix check_all Dec 26, 2023
Merged via the queue into openimsdk:main with commit 83864e3 Dec 26, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git skiffer-git approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Other]: remove zk test tool and fix check_all
4 participants
@AndrewZuo01 @FGadvancer @skiffer-git @cubxxw