Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special rule for Hungarian fixed holidays on Tuesdays and Thursdays #449

Open
urbalazs opened this issue Aug 23, 2023 · 1 comment
Open
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation.

Comments

@urbalazs
Copy link

In Hungary, we have a special rule for public holidays: if a public holiday is on Tuesday or on Thursday, then Monday or Friday will be also public holiday (Hungarians call it "resting day", do not need to work), but a Saturday before or after will be working day and act as Monday or Friday.

Here is an example:

20th of August is a fixed date public holiday in Hungary. In 2024, this is on Tuesday. Because of this, 19th of August (Monday) is a "resting day" (basically a public holiday), but 3rd of August (Saturday) is a working day and everything is open as it would be a Monday.

In this year (2023) it was not an issue since 20th of August was on Sunday, which is already a not working day.

TL;DR: in 2024

  • 3rd of August, Saturday is working day as it would be a Monday
  • 19th of August, Monday is public holiday as it was already worked on 3rd of August
  • 20th of August, Tuesday is a fixed date public holiday

Is there any chance to map such a variable date holiday and working day in this project?

@ypid
Copy link
Member

ypid commented Aug 27, 2023

Please first check if this is already implemented elsewhere, see #300
https://github.com/KDE/kholidays/blob/master/holidays/plan2/holiday_hu_hu

If you can express it in JavaScript, feel free to implement it. See function getMovableEventsForYear in https://github.com/opening-hours/opening_hours.js/blob/master/src/index.js.

@ypid ypid added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation. label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation.
Projects
None yet
Development

No branches or pull requests

2 participants