Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339494: Porting HalfFloatVector classes. #1233

Draft
wants to merge 1 commit into
base: lworld+fp16
Choose a base branch
from

Conversation

jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Sep 3, 2024

  • Port existing HalfFloatVector and its concrete vector classes from vectorIntrinsics+fp16 to lworld+fp16.
  • These new vector classes uses Float16 array as their backing storage.
  • Idea is to enable intrinsificaiton of new HalfFloatVector operations and leverage existing Float16 auto-vectorization and backend support.

All existing VectorAPI tests are passing with the patch.

Best Regards,
Jatin

Follow up work:-
a) Jtreg suite extensions to cover HalfFloatVector operations.
b) Handle Float16 lane type in vector API inline expansion layer.


Progress

  • Change must not contain extraneous whitespace

Warning

 ⚠️ Found trailing period in issue title for 8339494: Porting HalfFloatVector classes.

Issue

  • JDK-8339494: Porting HalfFloatVector classes. (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1233/head:pull/1233
$ git checkout pull/1233

Update a local copy of the PR:
$ git checkout pull/1233
$ git pull https://git.openjdk.org/valhalla.git pull/1233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1233

View PR using the GUI difftool:
$ git pr show -t 1233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1233.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2024

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into lworld+fp16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@jatin-bhateja This change is no longer ready for integration - check the PR body for details.

@mlbridge
Copy link

mlbridge bot commented Sep 3, 2024

Webrevs

@jatin-bhateja jatin-bhateja marked this pull request as draft September 4, 2024 02:06
@openjdk openjdk bot removed ready rfr labels Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 29, 2024

@jatin-bhateja this pull request can not be integrated into lworld+fp16 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8339494
git fetch https://git.openjdk.org/valhalla.git lworld+fp16
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld+fp16"
git push

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@jatin-bhateja This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant