Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: MDPSolver: An Efficient Solver for Markov Decision Processes #7084

Closed
editorialbot opened this issue Aug 7, 2024 · 39 comments
Closed
Assignees
Labels
C++ CMake pre-review Python Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 7, 2024

Submitting author: @areenberg (Anders Reenberg Andersen)
Repository: https://github.com/areenberg/MDPSolver
Branch with paper.md (empty if default branch): joss_paper
Version: v0.9.7
Editor: @kellyrowland
Reviewers: @gartavanis
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570"><img src="https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570/status.svg)](https://joss.theoj.org/papers/1547b20490a54135a20403c97cad6570)

Author instructions

Thanks for submitting your paper to JOSS @areenberg. Currently, there isn't a JOSS editor assigned to your paper.

@areenberg if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.23 s (1167.8 files/s, 309448.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    49           2854           3327          15094
C++                             69           2031           1857          12100
Python                          73           3004           1615          10561
reStructuredText                32           3154           2979           5543
YAML                            17            362            184           1556
CMake                            9            245            286           1189
SVG                              2              0              0            854
Markdown                         5            159              0            465
TOML                             2             12              0             86
TeX                              1              7              0             64
JSON                             1              0              0             32
Bourne Shell                     1              5             12             27
INI                              1              0              0             22
CSS                              1              0              0              3
-------------------------------------------------------------------------------
SUM:                           263          11833          10260          47596
-------------------------------------------------------------------------------

Commit count by author:

   111	Anders Reenberg Andersen
     6	Jesper Fink Andersen
     2	jesperfink

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/9780470316887 is OK
- 10.1016/j.ejor.2021.07.007 is OK

MISSING DOIs

- No DOI given, and none found for title: Maintenance optimization for multi-component syste...
- No DOI given, and none found for title: pymdptoolbox
- 10.32614/cran.package.mdptoolbox may be a valid DOI for title: MDPtoolbox: Markov Decision Processes Toolbox
- No DOI given, and none found for title: Markov Decision Processes (MDP) Toolbox
- No DOI given, and none found for title: createMDP (Matlab)
- No DOI given, and none found for title: POMDPs.jl: A Framework for Sequential Decision Mak...

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 724

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Mat-dp: An open-source Python model for analysing material demand projections and their environmental implications, which result from building low-carbon systems.
Submitting author: @kcerva
Handling editor: @crvernon (Active)
Reviewers: @MoLi7, @nick-gorman
Similarity score: 0.7150

pymdp: A Python library for active inference in discrete state spaces
Submitting author: @conorheins
Handling editor: @emdupre (Active)
Reviewers: @seankmartin, @patrickmineault
Similarity score: 0.7111

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python
Submitting author: @davidtourigny
Handling editor: @marcosvital (Active)
Reviewers: @jdbrunner, @pstjohn, @synchon
Similarity score: 0.7096

POMDPStressTesting.jl: Adaptive Stress Testing for Black-Box Systems
Submitting author: @mossr
Handling editor: @sbenthall (Active)
Reviewers: @jarvist, @sambitdash
Similarity score: 0.7060

neworder: a dynamic microsimulation framework for Python
Submitting author: @virgesmith
Handling editor: @danielskatz (Active)
Reviewers: @platipodium, @tresoldi
Similarity score: 0.7031

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@editorialbot editorialbot added Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning and removed Track: 8 (MISC) Miscellaneous labels Aug 11, 2024
@crvernon
Copy link

@editorialbot invite @kellyrowland as editor

👋 @kellyrowland since we are wrapping up your other submission, do you think you can take this one on?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@kellyrowland
Copy link

sure, I can take this on.

@crvernon
Copy link

@editorialbot assign @kellyrowland as editor

Thanks @kellyrowland!

@editorialbot
Copy link
Collaborator Author

Assigned! @kellyrowland is now the editor

@kellyrowland
Copy link

hello @tbrown122387 @RomainAzais 👋 would you be interested in and available for reviewing this JOSS submission?

@tbrown122387
Copy link

@kellyrowland sorry no can do!

@kellyrowland
Copy link

hello @Volkershcmid @MichalisPanayides 👋 would you be interested in and available for reviewing this JOSS submission?

@MichalisPanayides
Copy link

@kellyrowland Sorry. Not available atm.

@RomainAzais
Copy link

hello @tbrown122387 @RomainAzais 👋 would you be interested in and available for reviewing this JOSS submission?

Hello! No, I can't deal with this submission right now. Sorry for my very late and negative reply.

@kellyrowland
Copy link

hello @TimKam @SuperKam91 👋 would you be interested in and available for reviewing this JOSS submission?

@kellyrowland
Copy link

hello @seankmartin @patrickmineault 👋 would you be interested in and available for reviewing this JOSS submission?

@kellyrowland
Copy link

@areenberg @arfon a heads up that I will be out of office starting September 30 and returning October 21. I'll be picking things up when I get back but maybe it would be good to ask if another editor could try to get reviewers for this in the meantime?

@patrickmineault
Copy link

This is a bit outside my wheelhouse unfortunately.

@kellyrowland
Copy link

hello @virgesmith @davidtourigny 👋 would you be interested in and available for reviewing this JOSS submission?

@davidtourigny
Copy link

davidtourigny commented Oct 30, 2024 via email

@virgesmith
Copy link

@kellyrowland sorry, pretty much out of scope for me too plus too busy anyway.

@kellyrowland
Copy link

@areenberg do you have any suggestions for potential reviewers?

@areenberg
Copy link

Hi @kellyrowland,

I have a few suggestions:

All of the above have recently authored JOSS papers on somewhat related topics.

Best regards, Anders

@kellyrowland
Copy link

thanks very much!

@kellyrowland
Copy link

hello @WilliamLwj @mwetz 👋 would you be interested in and available for reviewing this JOSS submission?

@WilliamLwj
Copy link

Hi @kellyrowland, sorry very busy these days. Not available at this moment for reviewing...

@kellyrowland
Copy link

hello @spinjet 👋 would you be interested in and available for reviewing this JOSS submission?

@kellyrowland
Copy link

hello @GurjeetSinghSangra 👋 would you be interested in and available for reviewing this JOSS submission?

@GurjeetSinghSangra
Copy link

I am sorry @kellyrowland , but currently I am very busy with some deadlines. It also seems out of my domain.

@kellyrowland
Copy link

hello @seankmartin @patrickmineault 👋 would you be interested in and available for reviewing this JOSS submission?

@kellyrowland
Copy link

@editorialbot add @gartavanis as reviewer

@editorialbot
Copy link
Collaborator Author

@gartavanis added to the reviewers list!

@kellyrowland
Copy link

thank you for volunteering to review this submission @gartavanis !

in general, we usually start the review once there are two reviewers assigned. however, if you're available to start your review in the immediate future and would like to get that going, I can create the review issue and ping other potential reviewers there - just let me know.

@gartavanis
Copy link

@kellyrowland Thank you, I am available to start now.

@kellyrowland
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ CMake pre-review Python Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests