Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent InfoFrame behaviour #71

Open
mukoki opened this issue Nov 9, 2022 · 2 comments
Open

Inconsistent InfoFrame behaviour #71

mukoki opened this issue Nov 9, 2022 · 2 comments

Comments

@mukoki
Copy link
Contributor

mukoki commented Nov 9, 2022

InfoFrame tool creates a single InfoFrame. If a new selection is done while InfoFrame is opened, its content is replaced by the new selection. That way, there is always one single info frame opened.
When using the keyboard shortcut, a new InfoFrame is created, whether it already exists or not. The user may end up with dozains of opened info frame. In this case, when a new selection is done, it is quite difficult to know which info frame is changed.

I think normal InfoFrame behaviour should be the first one (single frame), but there is room and need for the second behaviour which could be called "list". It could be something like an infoframe with a name and should not be updated when the selection is changed. On the other hand, it should be possible to perfom set operations like unioning or intersecting between two or more lists.

@edeso
Copy link
Member

edeso commented Nov 10, 2022

i'd vote to just streamline functionality to the one instance cursor tool behaviour.

@edeso
Copy link
Member

edeso commented Oct 7, 2024

we've got the plugin placed in several menus(see below) + the toolbar (as tool).

there is already a UniqueFeatureInfoPlugIn but that window does seem to get replaced when FeatureInfoPlugIn is run. my vote'd be to fixup UniqueFeatureInfoPlugIn to stay open and have FeatureInfoPlugIn use one window instance over the whole application where info selections are updated.

agreed?

    
    <!-- ======================= VIEW menu ================================= -->
    <plug-in>
        com.vividsolutions.jump.workbench.ui.plugin.FeatureInfoPlugIn
        <menus>
            <main-menu menupath="MenuNames.VIEW" install="true" />
        </menus>
    </plug-in>

    <!-- ================ LayerView Popup Menu =============================== -->
    <plug-in>
        com.vividsolutions.jump.workbench.ui.plugin.UniqueFeatureInfoPlugIn
        <menus>
            <layerview-popup install="true" />
        </menus>
    </plug-in>
    <plug-in>
        com.vividsolutions.jump.workbench.ui.plugin.FeatureInfoPlugIn
        <menus>
            <layerview-popup install="true" />
        </menus>
    </plug-in>

        <!-- ================ AttributeTab Popup Menu ============================== -->
    <plug-in>
        com.vividsolutions.jump.workbench.ui.plugin.FeatureInfoPlugIn
        <menus>
            <attributetab-popup install="true" />
        </menus>
    </plug-in>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants