Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize Browser #13

Open
johntom opened this issue Nov 18, 2013 · 7 comments
Open

Resize Browser #13

johntom opened this issue Nov 18, 2013 · 7 comments

Comments

@johntom
Copy link

johntom commented Nov 18, 2013

Hi,
I've just tried your html5 viewer and I'm very happy with my initial results. See
sample2.gtz.com for a collection of mostly photgrahps by Nina Meledandi. One issue is that the collection will always size to the orginal size of browser. For example,if you open the browser with a 5 inch width and then make it 9 inches the main image panel does not grow unless you reload the page.
Thanks much for all your work as this seems to be getting close to the Silverlight version and all things considered is quite impressive.
John

@mattleibow
Copy link

Hi, I am also going to have a problem with this. I'll have a look and see what needs doing... Or, has someone fixed this somewhere?

@mattleibow
Copy link

I have done some work on this. It was fairly straightforward, instead of passing the height and width to the View, I pass instead a function that is executed each time. This allows for the different sizes to be used in calculations.

I need to still find an easier way to contain the code for resizing the various controls. Originally, the height was fixed and the sidebars, headers, etc were pre-calculated, now they are dynamic. This is resulting in logic that assumed various heights to be come a bit off. (there are several places with "magic numbers" - hardcoded heights and widths)

Hopefully I will be able to commit something soon for feedback.

@johntom
Copy link
Author

johntom commented Nov 24, 2013

Thanks. 

Sent via the Samsung Galaxy S™III, an AT&T 4G LTE smartphone

-------- Original message --------
From: Matthew Leibowitz [email protected]
Date: 11/24/2013 3:43 PM (GMT-05:00)
To: openlink/html5pivotviewer [email protected]
Cc: "John R. Tomaselli" [email protected]
Subject: Re: [html5pivotviewer] Resize Browser (#13)

I have done some work on this. It was fairly straightforward, instead of passing the height and width to the View, I pass instead a function that is executed each time. This allows for the different sizes to be used in calculations.

I need to still find an easier was to contain the code for resizing the various controls. Originally, the height was fixed and the sidebars, headers, etc were pre-calculated, now they are dynamic. This is resulting in logic that assumed various heights to be come a bit off.

Hopefully I will be able to commit something soon for feedback.


Reply to this email directly or view it on GitHub.

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4158 / Virus Database: 3629/6851 - Release Date: 11/20/13

@mattleibow
Copy link

Ok, I have committed the first go at implementing the resize - you can see my fork. It is not complete yet - only the grid view works. I will be working on this this week. Any feedback is cool :) Let me know if you have any problems.

@mattleibow
Copy link

I have finished the next view now, bars, as well as some small bug fixes...

@mattleibow
Copy link

@johntom I have finished the changes needed to do the resize, you can use my fork, or wait for the changes to be merged.

@dpituerdesign
Copy link

Great fork, I use your resize version an it works very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants