Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure libMesh::ReplicatedMesh is used for LibMesh tallies #3208

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nuclearkevin
Copy link
Contributor

Description

This PR implements a quick check in LibMesh::LibMesh(libMesh::MeshBase& input_mesh ...) to ensure that the input_mesh points to a libMesh::ReplicatedMesh instance, alongside explicitly instantiating a libMesh::ReplicatedMesh in LibMesh::set_mesh_pointer_from_filename(...) (suggested by @pshriwise while discussing #3206). This enforces the currently assumed behaviour that the entire mesh exists on all MPI ranks.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant