Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off PR gh-actions deployment? #37

Open
sef43 opened this issue Dec 28, 2023 · 1 comment
Open

Turn off PR gh-actions deployment? #37

sef43 opened this issue Dec 28, 2023 · 1 comment

Comments

@sef43
Copy link
Contributor

sef43 commented Dec 28, 2023

Currently when a PR is made a gh-actions workflow tries to build and deploy the PR onto the gh-pages branch so it can be viewed. However, this only works correctly if the PR is made from a branch within the openmm/openmm-cookbook repo. It does not work from any personal forks of the cookbook. This is a github permissions issue which I do not think can be worked around.

As personal forks and PRing is the typical contribution method this gh-actions workflow becomes rather pointless and confusing by throwing workflow errors whenever someone makes a PR.

We could remove it. Or maybe make it only run if the PR comes from within the repo?
@peastman
Copy link
Member

How about removing it for PRs, but still running it on the main branch after it is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peastman @sef43