-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mayer and Wiberg-Lowdin bond-indices missing from some subsets #76
Comments
this link seems to imply that the bond indices should be available for ion-pairs |
No idea what's up with that. It seems to be by molecule, not subset. I just ran a count of how many molecules in each subset do or don't have Wiberg bond orders.
There are a few subsets for which every molecule has bond orders, but in most cases some molecules do and some don't. I queried the ion pairs dataset from QCArchive to see whether the data is missing there, or where it's a problem in the downloader script. For about half the records, no only are the Wiberg bond orders missing, but the whole @pavankum any idea what's going on? |
I tried to dig into it but I am getting |
@peastman Thanks for the response, I suppose I'm parsing the data correctly then, I just missed the issue in Dipeptides for some reason. I downloaded the dataset from Zenodo FWIW, I did not use the downloader script. |
@peastman : @bennybp helped me with the debug, data for the key "WIBERG_LOWDIN_INDICES" is populated for all the completed calculations, and data for a redundant key with spaces "WIBERG LOWDIN INDICES" is not present in all. I checked on the Ion Pairs dataset and I could see 1426 records with Wiberg indices if I used the right key and 1389 with the second one with spaces. I checked another small dataset, DES370K supplement, and I see 3631/3631 with the right key and 2004/3631 with the second one with spaces. On a side note, I got a conda env for accessing the legacy server from Ben, I was getting
|
Can you show how you're accessing it? I retrieve the records from the dataset with |
I think I was doing almost the same
|
Here's what I do: from qcportal import FractalClient
fc = FractalClient()
ds = fc.get_collection('Dataset', 'SPICE Ion Pairs Single Points Dataset v1.1')
spec = ds.list_records().iloc[0].to_dict()
recs = ds.get_records(method=spec['method'], basis=spec['basis'], program=spec['program'], keywords=spec['keywords'])
print([recs.iloc[i].record.extras.keys() for i in range(len(recs))]) For about half the records there are two keys: |
your call is accessing a different spec
|
The updated file is now available on Zenodo. Thanks for reporting this! |
After parsing the dataset I found that some or all of the Wiberg-Lowdin and Mayer indices are missing for some subsets, specifically for:
MBIS seems to be missing from DES370K Supplement and Ion-Pairs too, but from issue #48 I gather that this is to be expected since most conformations could not converge MBIS in those subsets.
I wanted to double check that it is indeed intended that the bond indices are missing from these subsets, and if so what is the reason for this (I found it strange that they are present in PubChem Set 6 but not in the rest).
I haven't checked if the bond-indices are missing for all conformations or just some of them.
(This is mostly to double-check that I'm parsing the datasets correctly, I don't really have a use for the bond-indices currently)
The text was updated successfully, but these errors were encountered: