Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename attribute "rate" in Rule object into "rates" #103

Open
lecuretFlowbird opened this issue Jul 25, 2022 · 1 comment
Open

rename attribute "rate" in Rule object into "rates" #103

lecuretFlowbird opened this issue Jul 25, 2022 · 1 comment
Milestone

Comments

@lecuretFlowbird
Copy link

Is your feature request related to a problem? Please describe.

Attribute "rate" is ambiguous because it is used in Rate object to describe a single integer value but object Rule also use it to named an array of object Rate.

Describe the solution you'd like

A better solution could be that attribute in Rule object to be changed to "rates" (in plural like "user_classes")

Is this a breaking change

  • Yes, breaking

Impacted Spec

  • Curbs
@michael-danko-passport
Copy link
Collaborator

I believe @lecuretFlowbird is correct that this can be misleading. While this would be a breaking change, I think we may also want to consider similar clarification outlined within #106

@michael-danko-passport michael-danko-passport modified the milestone: 2.0 Jul 26, 2022
@jlarsonOmahaNE jlarsonOmahaNE added this to the 1.0.1 milestone May 30, 2023
@schnuerle schnuerle modified the milestones: 1.0.1, 2.0 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants