Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6131: created a controller been to replace componet-scan with import tag #4625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephbate
Copy link
Contributor

@josephbate josephbate commented Apr 25, 2024

Description of what I changed

i have started

  1. created a controller-config.xml to create controller beans for classes
  2. replaced componet-scan with an import tag for the controller

however i have had a rough time trying to test if there is an improvement in the startup

  • i tried using the sdk and ran into some issues,
  1. version 2.14 and above cannot be used with the option; 3) MySQL 5.7 in SDK docker container (requires pre-installed Docker i keep getting errors while trying to build a server with docker
  2. when i used the lower ref-app versions are not compatible with the current core version release 2.7.0-SNAPSHOT

how can i test setup time with with sdk or any other option

Cc. @ibacher @dkayiwa

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@Seremba
Copy link
Contributor

Seremba commented Apr 30, 2024

@josephbate did you find time to read OpenMRS pull request tips here https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips?

@josephbate
Copy link
Contributor Author

@josephbate did you find time to read OpenMRS pull request tips here https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips?

please state what you want to clarify i dont understand what you're trying to suggest

@mherman22
Copy link
Member

@josephbate did you find time to read OpenMRS pull request tips here https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips?

please state what you want to clarify i dont understand what you're trying to suggest

Read through 1-4 of that document provided by @Seremba and update your PR

@josephbate josephbate changed the title created a controller been to replace componet-scan with impot tag TRUNK-6131: created a controller been to replace componet-scan with import tag May 7, 2024
@josephbate
Copy link
Contributor Author

@josephbate did you find time to read OpenMRS pull request tips here https://openmrs.atlassian.net/wiki/spaces/docs/pages/25477199/Pull+Request+Tips?

please state what you want to clarify i dont understand what you're trying to suggest

Read through 1-4 of that document provided by @Seremba and update your PR

this better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants