Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunck-6236: Change datatype of onset_date from datetime to date #4747

Open
wants to merge 1 commit into
base: 2.6.x
Choose a base branch
from

Conversation

njiddasalifu
Copy link

@njiddasalifu njiddasalifu commented Sep 13, 2024

Description of what I changed

Change datatype of onset_date from datetime to date

Issue I worked on

https://openmrs.atlassian.net/browse/TRUNK-6236

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@njiddasalifu
Copy link
Author

Hi @dkayiwa @ibacher @wluyima kindly review this PR

@wikumChamith
Copy link
Member

@njiddasalifu can you take a look at the build errors?

@dkayiwa
Copy link
Member

dkayiwa commented Sep 18, 2024

Are you able to successfully compile this locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants