(feat) O3-4223: Allow adding different order types in the order basket #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -547 kB (-3.31%) Total Size: 16 MB
ℹ️ View Unchanged
|
ibacher
reviewed
Nov 22, 2024
packages/esm-patient-orders-app/src/components/test-order.component.tsx
Outdated
Show resolved
Hide resolved
| @@ -119,6 +120,15 @@ const OrderBasket: React.FC<DefaultPatientWorkspaceProps> = ({ | |||
| })} | |||
| name="order-basket-slot" | |||
| /> | |||
| {config?.orderTypes?.length > 0 && | |||
| config?.orderTypes?.map((orderType) => ( | |||
There was a problem hiding this comment.
Suggested change
| config?.orderTypes?.map((orderType) => ( | |
| config.orderTypes.map((orderType) => ( |
packages/esm-patient-orders-app/src/order-basket/order-types/generic-order-panel.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/order-basket/order-types/generic-order-panel.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/order-basket/order-types/generic-order-type.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-tests-app/src/test-orders/add-test-order/test-order-form.component.tsx
Outdated
Show resolved
Hide resolved
|
I also want to be clear that we cannot merge this in if it breaks the existing lab order functionality in any way, so be careful that things still work there with no code or configuration changes for implementers. Since this is widely-used in production, we have less freedom to break things "just because". |
vasharma05
force-pushed
the
feat/add-order-types
branch
2 times, most recently
from
01b63e0
to
2097c05
Compare
vasharma05
force-pushed
the
feat/add-order-types
branch
2 times, most recently
from
c9c4195
to
bc1e953
Compare
vasharma05
force-pushed
the
feat/add-order-types
branch
from
bc1e953
to
e99c807
Compare
vasharma05
changed the title
vasharma05
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds new configuration points to allow placing orders for different order types ('order', 'testorder').
Screenshots
None
Related Issue
https://openmrs.atlassian.net/browse/O3-4223
Other