(fix) O3-3890 Help menu (and menu items) should use a standard Carbon… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Oct 22, 2024
src/tutorial/tutorial.test.tsx
Outdated
| render(<Tutorial />); | ||
|
|
||
| const menuItem = screen.getByText(/Tutorials/i); | ||
| fireEvent.click(menuItem); |
src/tutorial/tutorial.test.tsx
Outdated
Comment on lines
7
to
9
| jest.mock('@openmrs/esm-framework', () => ({ | ||
| showModal: jest.fn(), | ||
| })) |
There was a problem hiding this comment.
Suggested change
| jest.mock('@openmrs/esm-framework', () => ({ | |
| showModal: jest.fn(), | |
| })) | |
| const mockShowModal = jest.mocked('showModal'); |
And then replace showModal in assertions with mockShowModal. See https://o3-docs.openmrs.org/docs/frontend-modules/unit-and-integration-testing#you-should-not-need-to-use-partial-mocks for more context about why you shouldn't need to use partial mocks.
src/tutorial/styles.scss
Outdated
| } | ||
|
|
||
| .tutorialsText:hover { | ||
| background: #e8e8e8; |
There was a problem hiding this comment.
Suggested change
| background: #e8e8e8; | |
| background: colors.$white-hover; |
src/tutorial/styles.scss
Outdated
| @@ -28,3 +28,11 @@ | |||
|
|
|||
| } | |||
| } | |||
|
|
|||
| .tutorialsText { | |||
| padding: 0.5rem 0.5rem; | |||
There was a problem hiding this comment.
nit:
Suggested change
| padding: 0.5rem 0.5rem; | |
| padding: layout.$spacing-03; |
|
@Samstar10 May you please update this PR as per the changes requested.. |
Done @Vijaykv5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… menu
Requirements
For changes to apps
If applicable
Summary
I have updated the help menu to use standard carbon menu items. This PR is related to this PR, openmrs/openmrs-esm-core#1164.
Screenshots
Please find attached the screenshot.
Related Issue
https://openmrs.atlassian.net/browse/O3-3890
Other