Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank 1 tensor decomposition #63

Open
GeoffNN opened this issue Apr 3, 2021 · 3 comments
Open

Rank 1 tensor decomposition #63

GeoffNN opened this issue Apr 3, 2021 · 3 comments
Labels
type:enhancement New feature or request type:good first issue Good for newcomers type:help wanted Extra attention is needed

Comments

@GeoffNN
Copy link
Contributor

GeoffNN commented Apr 3, 2021

We'd like to have a tensor LMO for tensor nuclear norm constraints. Therefore, an implementation of https://hal.archives-ouvertes.fr/hal-01385538/file/SeROAP_final.pdf (or some other rank 1 tensor decomposition algorithm) would be nice.

Our NuclearNormBall.lmo should do this by default for tensor inputs of shape (batch_size, *shape).

@GeoffNN GeoffNN added type:enhancement New feature or request type:good first issue Good for newcomers type:help wanted Extra attention is needed labels Apr 3, 2021
@fabianp
Copy link
Member

fabianp commented Apr 5, 2021

random thought: can we get away with an (unbiased estimator of) the largest eigenvalue? We could get this for example from the power method + russian roulette

@GeoffNN
Copy link
Contributor Author

GeoffNN commented Apr 6, 2021

Good question -- how many iterations would you perform with RR? I think I'm currently doing 10 and it works well enough for the matrix LMO.

It might be more interesting for higher order tensors.

@fabianp
Copy link
Member

fabianp commented Apr 6, 2021

I don't know. Now that I think about it its not even clear that for the LMO an unbiased estimator is better than an inexact one (i.e., deterministic but with a bounded error as would be the case in truncated power method)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request type:good first issue Good for newcomers type:help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants