Skip to content
This repository has been archived by the owner on Jan 20, 2025. It is now read-only.

Refactor MigratorLEI into Migrations #234

Open
2 tasks
tiredpixel opened this issue Dec 13, 2023 · 0 comments
Open
2 tasks

Refactor MigratorLEI into Migrations #234

tiredpixel opened this issue Dec 13, 2023 · 0 comments

Comments

@tiredpixel
Copy link
Contributor

tiredpixel commented Dec 13, 2023

Refactor RegisterSourcesBods::Services::MigratorLEI into the new RegisterSourcesBods::Migrations method.

This is quite a small task, and the LEI migrations have already been run, but I think there's merit in refactoring and importing it, not only to clean up existing code, but also as a useful reference for how to migrate identifiers.

It should also include refactoring RegisterSourcesOC::Repositories::AddIdRepository search_scroll to use since-added RegisterCommon::Elasticsearch::Query search_scroll instead, further reducing duplication (one function at a time…).

  • RegisterSourcesBods::Services::MigratorLEI
  • RegisterSourcesOC::Repositories::AddIdRepository

This was noted as part of #222 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant