Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value needed for region if region information is missing #106

Open
LDSamson opened this issue Oct 10, 2024 · 1 comment
Open

Default value needed for region if region information is missing #106

LDSamson opened this issue Oct 10, 2024 · 1 comment

Comments

@LDSamson
Copy link
Collaborator

If no region is available, the region should default to something like other or Unknown. It is now not possible to select sites to review in mod_review_config if a region is not set:

grafik

Currently, regions are only added in apply_study_specific_fixes which is not ideal.

@LDSamson
Copy link
Collaborator Author

One way to generalize regions/ make them customizable:

We could add a new variable region_code in column_names in the metadata.

Then we can add somewhere in the metadata information about the regions, which we can use to create the region variable using a new add_regions() helper function
grafik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant