Review by records instead of subject_id & form_id "rv_row"
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merge branch 'jt-113-simplify_review_process' into jt-99-review_by_row # Conflicts: # R/fct_SQLite.R # man/db_save_review.Rd # tests/testthat/test-fct_SQLite.R # tests/testthat/test-mod_review_forms.R
Merge branch 'dev' into jt-99-review_by_row # Conflicts: # R/mod_review_forms.R # tests/testthat/test-mod_review_forms.R
jthompson-arcus
commented
Nov 20, 2024
jthompson-arcus
commented
Nov 20, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
LDSamson
reviewed
Nov 21, 2024
Merge branch 'dev' into jt-99-review_by_row # Conflicts: # DESCRIPTION # inst/golem-config.yml
LDSamson
reviewed
Nov 22, 2024
LDSamson
reviewed
Nov 22, 2024
LDSamson
reviewed
Nov 22, 2024
LDSamson
reviewed
Nov 22, 2024
LDSamson
requested changes
Nov 22, 2024
… be coerced to a data frame
…view in in a shinytest2 test
|
@jthompson-arcus I wanted to make some minor changes and then merge this branch, but I realized that bug #108 was reintroduced in this PR when testing interactively, and our tests did not capture it properly. I updated the tests so that they would now fail as expected, and have a look at it at a later moment. |
LDSamson
reviewed
Nov 28, 2024
Comment on lines
19
to
21
| "export": { | ||
|
|
||
| "test-review_save_error": false | ||
| } |
There was a problem hiding this comment.
This test is failing but I changed the snapshot manually to what it should show, for now
LDSamson
reviewed
Nov 28, 2024
| # Within a form, only items with a changed review state are updated and | ||
| # contain the new (current) time stamp. | ||
| dplyr::filter(timestamp == review_records$timestamp[1]) | ||
| if(isTRUE(all.equal(review_records_db, review_records, check.attributes = FALSE))){ |
There was a problem hiding this comment.
The issue is that this statement now fails: the data frame review_records contains all possible item updates, but in the database only records with a changed review status will be updated. Thus, this statement does not always return TRUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still lead up to addressing #99. Review process needs to depend on records being reviewed, not the
review_rowit currently does.