Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to subset or arrange verbose & critical output #35

Open
EeethB opened this issue Jun 12, 2023 · 0 comments
Open

Add functions to subset or arrange verbose & critical output #35

EeethB opened this issue Jun 12, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@EeethB
Copy link
Contributor

EeethB commented Jun 12, 2023

Overview

I find myself searching for all verbose/critical output that contains/doesn't contain e.g. hypotheses 2 & 4. This takes quite a lot of searching and scanning across blocks of numbers, sometimes tracking multiple rows/columns at the same time. And I get lost a lot doing this! Also, large enough graphs start cutting off critical output because of data length

Usage - subset()

So if you have some res <- test_graph(g, p, verbose = TRUE, critical = TRUE), these functions could say subset_test_results(res, c(2, 4), keep = TRUE, which = c("verbose", "critical")) and return a test object with

  1. verbose results filtered for intersections containing (or not containing if keep = FALSE) hypotheses 2 and 4
  2. critical results filtered for...
    1. Those same intersections?
    2. Or only the rows of critical containing hypotheses 2 or 4

Usage - sort()

There could also be one to sort_test_results(res, c(2, 4), first = TRUE, which = c("verbose", "critical")), which would keep all results, but put 2/4-related intersections first (last).

Related

#26 has some ideas about this related to formatting, and this issue could build on that, or be made separately.
#27 could also be related, as these could be done as generics for sort() and subset()`

@EeethB EeethB added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2023
@EeethB EeethB self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant