Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Problem matchers to surface failures prominently in the UI #37

Open
timtebeek opened this issue May 7, 2023 — with Slack · 4 comments
Open

Add Problem matchers to surface failures prominently in the UI #37

timtebeek opened this issue May 7, 2023 — with Slack · 4 comments
Labels
enhancement New feature or request

Comments

Copy link
Contributor

It looks like / FAILED$/ might be a pattern to match things, or possibly />.* FAILED$/.

https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md
n.b. the documentation is buggy, I thought I wrote a PR to fix it, but I can't find it 😞

Slack Message

@timtebeek timtebeek added the enhancement New feature or request label May 7, 2023 — with Slack
@timtebeek
Copy link
Contributor Author

Improved documentation here: https://github.com/actions/toolkit/pull/1414/files

@jsoref
Copy link

jsoref commented May 7, 2023

The /s above are to denote regular expressions. In the problem matcher syntax, you get to use Java style strings to represent regular expressions, which means using double-backslashes (\n => \\n) for builtin regular expression character classes (not applicable in the above example)

@timtebeek
Copy link
Contributor Author

Might also help to highlight any build scans where available, such as for instance:

Publishing build scan...
https://ge.openrewrite.org/s/cpl5aclixmt5s

@jsoref
Copy link

jsoref commented May 7, 2023

Here's a random sample reporter which might help as reading material:
https://github.com/check-spelling/check-spelling/blob/e3b1f361ff1ff04c15a891c14438cf077a87ae8e/reporter-misc.json
And here's the glue to connect it to GitHub:
https://github.com/check-spelling/check-spelling/blob/e3b1f361ff1ff04c15a891c14438cf077a87ae8e/unknown-words.sh#L1567

A warning: if you're running things using GitHub Action's Docker support, you may be unhappy (I haven't checked, but I don't think you are)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants