-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore @DocumentExamples
in the docs either through RewriteRecipeExamplesPlugin
or alternative
#20
Comments
I believe one problem was that it caused CI builds to be extremely slow or even time out in some repos (rewrite-cobol if I am not mistaken). @jkschneider or @sambsnyd will know more. Please verify that first again. Otherwise we could provide an explicit opt-in or opt-out property. |
Discussed internally as well. Main points copied here.
|
RewriteRecipeExamplesPlugin
@DocumentExamples
in the docs either through RewriteRecipeExamplesPlugin
or alternative
So as discussed on the stand up: we can potentially move this to rewrite-recipe-markdown-generator. The steps there are roughly:
That's very high over; there may be specifics or alternatives that I haven't thought of yet, but figured write this down such that Mike can challenge that. Again, this would only make those docs available on docs.openrewrite.org; unless we're able to fix the performance issues with the Alternatively we can only run the existing plugin when we for instance publish a release; but then still there's negative effects on getting a timely release out. |
Closing as a duplicate, with alternative approach listed here which does not require examples to be bundled. |
What problem are you trying to solve?
RewriteRecipeExamplesPlugin
was disabed in dec3f04 at the time when some recipes produced invalid yaml(?).Not exactly clear what circumstances lead to disabling the plugin; not ideal to retry without that context.
Describe the solution you'd like
Would like to see the examples restored in the docs and on the platform, as the
@DocumentExample
cases help visualize what effect a recipe has, in addition to the name and description.Have you considered any alternatives or workarounds?
We might call the
ExamplesExtractor
(or similar) from rewrite-recipe-markdown-generator, such that there's no risk of tripping up the platform with invalid Yaml resources.Additional context
The text was updated successfully, but these errors were encountered: