TypeTable should store actual version for predictable matching #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
commented
Feb 14, 2025
Comment on lines
+54
to
+56
| String version = dependency.getValue().getName() | ||
| .substring(artifact.length() + 1) | ||
| .replaceAll(".jar$", ""); |
There was a problem hiding this comment.
The API exposed by Gradle here is quite minimal, only showing the requested version. This naive wrangling I expect to mostly work, except in rare cases that I do not expect to encounter in parserClasspath entries just yet. Open to improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Determine the actual jar version number, as opposed to the requested version number.
What's your motivation?
We saw mismatches in
Anything in particular you'd like reviewers to focus on?
Called out in comments. Tagged Sam for async review.
Have you considered any alternatives or workarounds?
We could adjust the matching as well, but then we'd be storing
../5.+/..on disk, which could be5.0 - 5.3. This avoids confusion.